Commit 9ad7de9e authored by FichteFoll's avatar FichteFoll

Sort package key tests lexigographically

At least somewhat.
parent e37e20f7
...@@ -296,17 +296,15 @@ class TestContainer(object): ...@@ -296,17 +296,15 @@ class TestContainer(object):
for k, v in data.items(): for k, v in data.items():
self.enforce_key_types_map(k, v, self.package_key_types_map) self.enforce_key_types_map(k, v, self.package_key_types_map)
if k == 'donate' and v is None: if k == 'details':
# Allow "removing" the donate url that is added by "details"
continue
elif k in ('homepage', 'readme', 'issues', 'donate', 'buy'):
self.assertRegex(v, '^https?://')
elif k == 'details':
self.assertRegex(v, self.package_details_regex, self.assertRegex(v, self.package_details_regex,
'The details url is badly formatted or ' 'The details url is badly formatted or '
'invalid') 'invalid')
elif k == 'donate' and v is None:
# Allow "removing" the donate url that is added by "details"
continue
elif k == 'previous_names': elif k == 'previous_names':
# Test if name is unique, against names and previous_names. # Test if name is unique, against names and previous_names.
for prev_name in v: for prev_name in v:
...@@ -325,6 +323,9 @@ class TestContainer(object): ...@@ -325,6 +323,9 @@ class TestContainer(object):
(prev_name, include, name) (prev_name, include, name)
) )
elif k in ('homepage', 'readme', 'issues', 'donate', 'buy'):
self.assertRegex(v, '^https?://')
# Test for invalid characters (on file systems) # Test for invalid characters (on file systems)
# Invalid on Windows (and sometimes problematic on UNIX) # Invalid on Windows (and sometimes problematic on UNIX)
self.assertNotRegex(name, r'[/?<>\\:*|"\x00-\x19]', self.assertNotRegex(name, r'[/?<>\\:*|"\x00-\x19]',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment